Vinz2168 opened a new pull request, #11940: URL: https://github.com/apache/nifi/pull/11940
<!-- Licensed to the Apache Software Foundation (ASF) under one or more --> <!-- contributor license agreements. See the NOTICE file distributed with --> <!-- this work for additional information regarding copyright ownership. --> <!-- The ASF licenses this file to You under the Apache License, Version 2.0 --> <!-- (the "License"); you may not use this file except in compliance with --> <!-- the License. You may obtain a copy of the License at --> <!-- http://www.apache.org/licenses/LICENSE-2.0 --> <!-- Unless required by applicable law or agreed to in writing, software --> <!-- distributed under the License is distributed on an "AS IS" BASIS, --> <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --> <!-- See the License for the specific language governing permissions and --> <!-- limitations under the License. --> # Summary [NIFI-16602](https://issues.apache.org/jira/browse/NIFI-16602) `NifiDiscriminator` iterates over `ILoggingEvent.getKeyValuePairs()` without a null check. Logback returns `null` for events without key/value pairs, so the `DEDICATED_LOGGING` appender (enabled by default in `logback.xml`) throws a `NullPointerException` for nearly every log event. Logback swallows the exception, so the output is correct, but every event pays for an exception and "failed to append" errors are recorded in the logback status. A null check in the discriminator is not a valid fix: when the discriminating value is `null`, `SiftingAppenderBase` routes the event to an appender for the undefined key. As a result, every event without a suffix is written to an additional `nifi-app-logFileSuffix_IS_UNDEFINED.log` file. This PR: - adds `LogFileSuffixFilter` to `nifi-per-process-group-logging`. The filter returns `DENY` for events without the `logFileSuffix` key/value pair and `NEUTRAL` otherwise, so those events never reach the discriminator; - adds the filter to the `DEDICATED_LOGGING` appender in the default `logback.xml`; - leaves `NifiDiscriminator` unchanged, so existing `logback.xml` files that do not reference the filter keep their current behavior. Verified with a standalone logback 1.6.6 setup: with the filter there are no appender errors and no additional files, and only events with a suffix reach the dedicated file. The MiNiFi `logback.xml` will need the same filter line once #11912 (NIFI-16572) is merged. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` - [ ] Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `./mvnw clean install -P contrib-check` - [ ] JDK 21 - [ ] JDK 25 `nifi-per-process-group-logging` module built with `-P contrib-check` (unit tests, checkstyle, PMD, RAT) on JDK 26. ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files No new dependencies. ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
