markobean opened a new pull request, #11937: URL: https://github.com/apache/nifi/pull/11937
<!-- Licensed to the Apache Software Foundation (ASF) under one or more --> <!-- contributor license agreements. See the NOTICE file distributed with --> <!-- this work for additional information regarding copyright ownership. --> <!-- The ASF licenses this file to You under the Apache License, Version 2.0 --> <!-- (the "License"); you may not use this file except in compliance with --> <!-- the License. You may obtain a copy of the License at --> <!-- http://www.apache.org/licenses/LICENSE-2.0 --> <!-- Unless required by applicable law or agreed to in writing, software --> <!-- distributed under the License is distributed on an "AS IS" BASIS, --> <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --> <!-- See the License for the specific language governing permissions and --> <!-- limitations under the License. --> # Summary Changed the behavior of the "Reorder rules" option to UpdateAttribute advanced UI. See Jira for a specific example of where it can become problematic. In addition, the changes now allow users to reorder rules regardless of the policy, clone or original. There are times when users want to reorder rules even when using clone even though order does matter _functionally_. There are other reasons to want to specify a particular order. Updated tooltip of the original/clone policy. Added a tooltip to reorder rules option. Both provide increased detail to explain how reordering works, and when it does not. For example, rules cannot be reordered if they have been limited by search criteria. Minor update to the processor's Additional Details correcting for the new behavior and fixing a leftover from NiFi 1.x which is now different in 2.x. [NIFI-16553](https://issues.apache.org/jira/browse/NIFI-16553) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` - Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status ### Pull Request Formatting - Pull Request based on current revision of the `main` branch - Pull Request refers to a feature branch with one commit containing changes # Verification Implemented in a running NiFi to confirm proper behavior: - Reorder rules toggle is visible all the time - Toggle cannot be enabled if the rules have been filtered with a search criteria - Toggle cannot be enabled when there are unsaved rule change - Rules can be reordered even if one or more rules is expanded. (See PR #11930 for NIFI-16568 for Expand All / Collapse All option.) - Rules cannot be modified or added when reordering is enabled ### Build - [X] Build completed using `./mvnw clean install -P contrib-check` - [X] JDK 21 - [ ] JDK 25 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [X] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
