mcgilman commented on code in PR #11774:
URL: https://github.com/apache/nifi/pull/11774#discussion_r4606824968


##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/state/extension-types/extension-types.reducer.ts:
##########
@@ -48,7 +46,6 @@ export const extensionTypesReducer = createReducer(
     on(

Review Comment:
   Removing `loadExtensionTypesForPolicies` leaves three actions in this 
`on(...)` call, so Prettier now expects the call to fit on one line. The 
current formatting produces 12 `prettier/prettier` lint errors. Please run the 
formatter and confirm that `nifi:lint` passes. The resulting call should begin 
with:
   
   ```ts
   on(loadExtensionTypesForCanvas, loadExtensionTypesForSettings, 
loadExtensionTypesForDocumentation, (state) => ({
   ```
   
   ---
   <sub>🤖 Posted by an AI agent (Cursor · skill `pr-reviewer`) on behalf of 
@mcgilman.</sub>
   <!-- agent-attribution v1: agent=cursor; skill=pr-reviewer; 
operator=mcgilman -->



##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/users/ui/user-listing/user-access-policies/user-access-policies.component.ts:
##########
@@ -99,11 +99,8 @@ export class UserAccessPolicies extends CloseOnEscapeDialog {
     }
 
     formatPolicy(policy: AccessPolicySummaryEntity): string {
-        if (policy.component.resource.startsWith('/restricted-components')) {

Review Comment:
   Removing this branch causes existing `/restricted-components` policies to 
fall through to `unknownResourceParser()` and appear as “Unknown resource.” The 
backend continues to recognize these legacy policies through 
`LEGACY_RESTRICTED_COMPONENTS_AUTHORIZABLE`, so users may still encounter them 
after upgrading. Please retain fallback text for these policies—such as “Legacy 
restricted components policy”—so users can identify them. This does not need to 
preserve the previous detailed restriction labels.
   
   ---
   <sub>🤖 Posted by an AI agent (Cursor · skill `pr-reviewer`) on behalf of 
@mcgilman.</sub>
   <!-- agent-attribution v1: agent=cursor; skill=pr-reviewer; 
operator=mcgilman -->



##########
nifi-docs/src/main/asciidoc/user-guide.adoc:
##########
@@ -2787,109 +2770,6 @@ Version 1 of a flow does not have a Parameter Context 
associated with it. A new
 - An existing Parameter Context is assigned (by name) to the Process Group and 
the values of the Parameter Contexts are merged
 
 
-[[Restricted_Components_in_Versioned_Flows]]
-=== Restricted Components in Versioned Flows

Review Comment:
   The sections removed from this guide contained the only references to the 
following 24 images. I confirmed that none has another source reference after 
this change. Please delete them from `nifi-docs/src/main/asciidoc/images/`:
   
   - `restricted.png`
   - `sys_admin-restricted-component-access-policy.png`
   - `test_user-restricted-component-read-filesystem.png`
   - `test_user-restricted-component-write-filesystem.png`
   - `keytabCredentialsService-rpg.png`
   - `keytabCredentialsService-pg.png`
   - `keytabcredentialsservice-permissions.png`
   - `abc-restricted-component-flow.png`
   - `abc-versioned-flow.png`
   - `getfile-permissions.png`
   - `puthdfs-permissions.png`
   - `puthdfs-properties.png`
   - `puthdfs-properties_2.png`
   - `puthdfs-no-kerberosCS.png`
   - `test_user-revert-local-changes.png`
   - `test_user-revert-local-changes-2.png`
   - `revert-success.png`
   - `revert-failure.png`
   - `test_user-import-abc-flow.png`
   - `test_user-import-success.png`
   - `test_user-import-xyz-flow.png`
   - `import-xyz-flow-fails.png`
   - `xyz-process-group.png`
   - `xyz-flow.png`
   
   ---
   <sub>🤖 Posted by an AI agent (Cursor · skill `pr-reviewer`) on behalf of 
@mcgilman.</sub>
   <!-- agent-attribution v1: agent=cursor; skill=pr-reviewer; 
operator=mcgilman -->



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to