pvillard31 opened a new pull request, #11932:
URL: https://github.com/apache/nifi/pull/11932

   # Summary
   
   NIFI-16594 - Preserve node statuses received during flow synchronization on 
reconnection
   
   When a node handles a reconnection request, 
`StandardFlowService.handleReconnectionRequest` applies the node connection 
statuses from the request twice. The first time is before the flow is loaded, 
via `loadFromConnectionResponse` → `initializeNodeConnectionState`. The second 
time is through `ClusterCoordinator.resetNodeStatuses` after the flow has been 
loaded. Because `resetNodeStatuses` replaces statuses unconditionally, any 
status update the node received while synchronizing the flow is reverted to the 
older value from the request.
   
   If a peer became `CONNECTED` during that window, the reconnecting node keeps 
seeing it as `CONNECTING`. If the node is then offloaded, for example 
decommissioned shortly after a rolling restart, its load-balanced queues never 
transfer FlowFiles to that peer. The load-balance client only sends to 
`CONNECTED` peers, and heartbeats stop at disconnect, so the view is never 
corrected. The offload stays in `OFFLOADING` indefinitely, with FlowFiles left 
on the node, until the node is restarted.
   
   The second application should be replaced by a notification of the current 
statuses to cluster topology listeners. Queues created while loading the flow 
still align with the current topology, without reverting newer statuses. The 
comment on `resetNodeStatuses`, which describes an update-id comparison it 
doesn't perform, should also be corrected.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-00000`
   - Pull Request commit message starts with Apache NiFi Jira issue number, as 
such `NIFI-00000`
   - Pull request contains [commits 
signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits)
 with a registered key indicating `Verified` status
   
   ### Pull Request Formatting
   
   - Pull Request based on current revision of the `main` branch
   - Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [ ] Build completed using `./mvnw clean install -P contrib-check`
     - [ ] JDK 21
     - [ ] JDK 25
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to