markobean commented on PR #11901:
URL: https://github.com/apache/nifi/pull/11901#issuecomment-6930911368

   > Reviewed, and this does show Lineage query errors now. However, I suggest 
clearing the error when performing a new lineage query. It appears that the 
code already supports doing this, we just have to include the LINEAGE context.
   > 
   > Suggested change provenance-event-listing.component.ts line 218:
   > 
   > ```
   > clearBannerErrors(): void {
   >     this.store.dispatch(clearBannerErrors({ context: 
ErrorContextKey.PROVENANCE }));
   >     this.store.dispatch(clearBannerErrors({ context: 
ErrorContextKey.LINEAGE }));
   > }
   > ```
   > 
   > If we don't do this, the error is still displayed if you do a new 
successful lineage query:
   > 
   > 1. Open lineage and trigger an expansion error.
   > 2. Return to the event list without dismissing the banner.
   > 3. Open lineage for another event whose query succeeds.
   > 4. The previous error remains displayed
   
   Good catch. I added the suggested line to clear the lineage errors from the 
banner.
   Thanks @mosermw 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to