bobpaulin commented on code in PR #11872:
URL: https://github.com/apache/nifi/pull/11872#discussion_r4556231900


##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java:
##########
@@ -3870,11 +3873,17 @@ public ConnectorEntity scheduleConnector(final Revision 
revision, final String i
 
         final RevisionUpdate<ConnectorDTO> snapshot = 
revisionManager.updateRevision(claim, user, () -> {
             switch (state) {
-                case RUNNING -> connectorDAO.startConnector(id);
+                case RUNNING -> connectorDAO.startConnector(id, 
controllerFacade::saveImmediate);

Review Comment:
   [Claude Opus 5.5] Both call the same thing: 
`ControllerFacade.saveImmediate()` just delegates to 
`flowService.saveFlowChanges()`, which is what 
`FlowController.saveFlowAfterConnectorEvolution` calls. They differ only 
because the facade can't reach the `FlowController` helper and `FlowController` 
has no `ControllerFacade`. I can expose the `FlowController` method and use it 
from the facade if you'd prefer a single path.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to