markap14 commented on code in PR #11857:
URL: https://github.com/apache/nifi/pull/11857#discussion_r4485694183


##########
nifi-extension-bundles/nifi-kafka-bundle/nifi-kafka-service-api/src/main/java/org/apache/nifi/kafka/service/api/record/ByteRecord.java:
##########
@@ -45,6 +46,20 @@ public ByteRecord(
             final byte[] key,
             final byte[] value,
             final long bundledCount
+    ) {
+        this(topic, partition, offset, timestamp, headers, key, value, 
bundledCount, false);
+    }
+
+    public ByteRecord(
+            final String topic,
+            final int partition,
+            final long offset,
+            final long timestamp,
+            final List<RecordHeader> headers,
+            final byte[] key,
+            final byte[] value,
+            final long bundledCount,
+            final boolean tombstone

Review Comment:
   We should avoid overriding the production test code constructor just to make 
it more convenient for tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to