lordgamez commented on code in PR #2292:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2292#discussion_r4481353802
##########
minifi_main/MiNiFiMain.cpp:
##########
@@ -79,6 +81,41 @@ namespace utils = minifi::utils;
static std::atomic_flag flow_controller_running;
static std::atomic_flag process_running;
+enum class LifecycleState : int32_t {
+ RUNNING,
+ RESTART_REQUESTED,
+ SHUTDOWN_REQUESTED
+};
+
+struct LifecycleRequest {
+ LifecycleState state = LifecycleState::RUNNING;
+ int32_t exit_code = 0;
+};
+
+static_assert(std::atomic<LifecycleRequest>::is_always_lock_free);
Review Comment:
I agree it's not obvious and it could use an explanation, added a message
and a comment in
https://github.com/apache/nifi-minifi-cpp/pull/2292/commits/4113ab830ab42d6fd7b2d9f42280e356ae33e86b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]