pvillard31 commented on code in PR #11856:
URL: https://github.com/apache/nifi/pull/11856#discussion_r4403778930
##########
nifi-registry/nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/service/extension/docs/HtmlExtensionDocWriter.java:
##########
@@ -118,9 +118,8 @@ private void writeBody(final ExtensionMetadata
extensionMetadata, final Extensio
*
* @param extension the component to describe
* @param xmlStreamWriter the stream writer
- * @throws XMLStreamException thrown if there was a problem writing to the
XML stream
*/
- protected void writeAdditionalBodyInfo(final Extension extension, final
XMLStreamWriter xmlStreamWriter) throws XMLStreamException {
+ protected void writeAdditionalBodyInfo(final Extension extension, final
XMLStreamWriter xmlStreamWriter) {
Review Comment:
Can we keep `throws XMLStreamException` on this documented subclass hook, so
overrides can propagate failures from `XMLStreamWriter` without catching or
wrapping them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]