boguszj opened a new pull request, #11859: URL: https://github.com/apache/nifi/pull/11859
<!-- Licensed to the Apache Software Foundation (ASF) under one or more --> <!-- contributor license agreements. See the NOTICE file distributed with --> <!-- this work for additional information regarding copyright ownership. --> <!-- The ASF licenses this file to You under the Apache License, Version 2.0 --> <!-- (the "License"); you may not use this file except in compliance with --> <!-- the License. You may obtain a copy of the License at --> <!-- http://www.apache.org/licenses/LICENSE-2.0 --> <!-- Unless required by applicable law or agreed to in writing, software --> <!-- distributed under the License is distributed on an "AS IS" BASIS, --> <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --> <!-- See the License for the specific language governing permissions and --> <!-- limitations under the License. --> # Summary [NIFI-16519](https://issues.apache.org/jira/browse/NIFI-16519) Remove coupling between component scheduling and ComponentMetricContext lifecycle Currently, `ComponentMetricContext` is created and cached in `AbstractRepositoryContext`. This means it updates only when `AbstractRepositoryContext` is re-created which for components is when they are scheduled. When a flow is upgraded, then only the components that were changed across versions are re-scheduled. All other ones keep running, so they don't get a VCI update. Given that the lifecycle of `AbstractRepositoryContext` is tied to component scheduling and `ComponentMetricContext` is not, this PR removes this coupling. `Connectable` is already exposed from `RepositoryContext` anyway and it holds a reference to an always up-to-date version of logging attributes, so the consumers can use that to build an up-to-date instance of `ComponentMetricContext` when needed. Additional allocation is small and should have no impact on performance, because all paths in which it is used already allocate on per-call basis. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` - Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status ### Pull Request Formatting - Pull Request based on current revision of the `main` branch - Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `./mvnw clean install -P contrib-check` - [x] JDK 21 - [ ] JDK 25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
