3Juhwan opened a new pull request, #11795: URL: https://github.com/apache/nifi/pull/11795
<!-- Licensed to the Apache Software Foundation (ASF) under one or more --> <!-- contributor license agreements. See the NOTICE file distributed with --> <!-- this work for additional information regarding copyright ownership. --> <!-- The ASF licenses this file to You under the Apache License, Version 2.0 --> <!-- (the "License"); you may not use this file except in compliance with --> <!-- the License. You may obtain a copy of the License at --> <!-- http://www.apache.org/licenses/LICENSE-2.0 --> <!-- Unless required by applicable law or agreed to in writing, software --> <!-- distributed under the License is distributed on an "AS IS" BASIS, --> <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --> <!-- See the License for the specific language governing permissions and --> <!-- limitations under the License. --> # Summary [NIFI-16450](https://issues.apache.org/jira/browse/NIFI-16450) PublishKafka exposes `Kafka Key Attribute Encoding` with the `KeyEncoding` allowable values, but reads the property as a raw string and hands it to `String.getBytes(charsetName)` in `AttributeKeyFactory`. Only `utf-8` happens to be a valid charset name, so selecting `Hex Encoded` fails every keyed FlowFile with `UnsupportedEncodingException: hex` and routes it to `failure`. The publish path has no hexadecimal decoding at all, so a binary key consumed with `Hex Encoded` cannot be published back as the original bytes, which `PublishKafka_2_6` supported. `AttributeKeyFactory` now takes `KeyEncoding` and branches on it: `HEX` decodes the value with `HexFormat` (case-insensitive, so keys written by both 1.x and 2.x ConsumeKafka round-trip), `UTF8` uses the UTF-8 bytes, and `DO_NOT_ADD` publishes without a key. Malformed hex raises `IllegalArgumentException`, which the existing publish callback already routes to `failure`. `PublishKafka` reads the property with `asAllowableValue(KeyEncoding.class)`, matching the other enum-backed properties of the processor. Behavior for the default `UTF-8 Encoded` is unchanged. Unit tests cover each encoding in `AttributeKeyFactoryTest`, and `PublishKafkaTest` gains processor-level tests that capture the `KafkaRecord` key handed to the producer for hex, UTF-8 and invalid hex input. `Do Not Add Key as Attribute` has no meaning for a publisher. It is kept as an allowable value so existing flows stay valid and is treated as "no key"; happy to remove it from PublishKafka instead, and to reword the property description (currently copied from ConsumeKafka), if preferred. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` - Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status ### Pull Request Formatting - Pull Request based on current revision of the `main` branch - Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. `nifi-kafka-processors` built and tested with `./mvnw -pl nifi-extension-bundles/nifi-kafka-bundle/nifi-kafka-processors -P contrib-check verify` on JDK 21: 56 tests passed, no Checkstyle violations. No new dependencies and no documentation changes. ### Build - [ ] Build completed using `./mvnw clean install -P contrib-check` - [ ] JDK 21 - [ ] JDK 25 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
