anshuksi282-ksolves opened a new pull request, #11792: URL: https://github.com/apache/nifi/pull/11792
# Summary [NIFI-16444](https://issues.apache.org/jira/browse/NIFI-16444) When a Controller Service property is set to a Parameter reference such as `#{aws-cs}` and the Parameter has no value at flow load, `isPropertySet()` and `getPropertyValue()` report the property as unset. Migrations that create a default Controller Service for an unset property then create one and overwrite the Parameter reference, which is persisted to the flow. The fix checks `getRawPropertyValue()` for the Controller Service property in three migrations: - `AbstractAwsProcessor` (AWS Credentials Provider Service) - `PutElasticsearchRecord` (Result Record Writer) - `StandardSnowflakeIngestManagerProviderService` (Web Client Service Provider) `StandardPropertyConfiguration.isPropertySet()` is unchanged because other migrations rely on a Parameter without a value being treated as unset for plain properties. Tests: - `TestStandardPropertyConfiguration` covers the raw and effective values of a Parameter reference without a value. - `TestFetchS3Object`, `PutElasticsearchRecordTest` and `TestStandardSnowflakeIngestManagerProviderService` verify that no Controller Service is created and the Parameter reference is retained. The new tests fail without the change to the migration code and pass with it. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` - [x] Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `./mvnw clean install -P contrib-check` - [ ] JDK 21 - [ ] JDK 25 Build verification was run for the changed modules (`nifi-framework-components`, `nifi-aws-abstract-processors`, `nifi-aws-processors`, `nifi-elasticsearch-restapi-processors`, `nifi-snowflake-services`) with `-P contrib-check` (Checkstyle, PMD, license check) on JDK 21 and JDK 25, and the unit tests of those modules pass on both. ### Licensing - [x] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [x] New dependencies are documented in applicable `LICENSE` and `NOTICE` files No new dependencies were added. ### Documentation - [x] Documentation formatting appears as expected in rendered files No documentation files were changed. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
