joewitt opened a new pull request, #11699: URL: https://github.com/apache/nifi/pull/11699
# Summary [NIFI-16371](https://issues.apache.org/jira/browse/NIFI-16371) Fixes a 1-in-256 flake in `PasswordBasedPropertyEncryptionProviderTest.testDecryptAuthenticationFailed`. The test encrypted a value then assigned `encrypted[0] = 0` before asserting that decryption throws. Encrypted output starts with a random AES-GCM IV, so that assignment is a no-op whenever the first IV byte is already zero. Decryption then succeeds and the assertion fails. The assignment is now a bit flip (`encrypted[0] ^= 1`) so the ciphertext is always mutated. # Tracking ### Issue Tracking - [X] Apache NiFi Jira issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number - [X] Pull Request commit message starts with Apache NiFi Jira issue number - [X] Pull request contains commits signed with a registered key indicating `Verified` status ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification ### Build - [ ] Build completed using `./mvnw clean install -P contrib-check` - [ ] JDK 21 - [ ] JDK 25 `PasswordBasedPropertyEncryptionProviderTest` (11 tests) passed, then `testDecryptAuthenticationFailed` passed 30 additional consecutive Maven runs. ### Licensing No new dependencies. ### Documentation No documentation changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
