markap14 commented on PR #11677: URL: https://github.com/apache/nifi/pull/11677#issuecomment-5733202949
[grok-4.6] Correction pushed as b4b8ca8e724. The PR is still in draft until the full system test suite finishes. To be clear about what changed versus my earlier mistake: the framework still discards a stored property or configuration step that the current Connector version does not declare, but it no longer treats that as a free-standing deletion. Two things it deliberately does not do at that moment: - it does not push the configuration to the `ConnectorConfigurationProvider` - it does not reclaim any Asset the discarded value referenced Those happen when the user applies a configuration, which is the point at which the configuration is pushed to the provider and Assets no longer referenced by either the active or working configuration are reclaimed. An Asset stays available until then. Why discard at all: the stored value is not visible to the current version, and `StandardConnectorConfigurationContext.setProperties` merges rather than replaces, so the UI cannot clear a property it does not know exists. Left in place, the Connector reports invalid for a property the user has no way to remove. Tests: - `TestStandardConnectorNode` verifies a replacement drops an undeclared property and configuration step, keeps declared values, and leaves the referenced Asset intact. Verified it fails without the change. - `TestStandardConnectorRepository` verifies applying an update reclaims Assets no longer referenced. Verified it fails if the cleanup call is removed. - `ConnectorChangeVersionIT` now changes 1.0.0 to 2.0.0 and back, then exercises Troubleshooting on the reverted version. All 57 connector system tests and the 760 nifi-framework-core unit tests pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
