martinzink commented on code in PR #2225: URL: https://github.com/apache/nifi-minifi-cpp/pull/2225#discussion_r4037278667
########## minifi_rust/extensions/minifi_pgp/src/processors/decrypt_content.rs: ########## @@ -0,0 +1,399 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// https://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use proc_def::*; + +use crate::controller_services::private_key_service::PGPPrivateKeyService; + +use minifi_native::macros::ComponentIdentifier; +use minifi_native::{ + FlowFileStreamTransform, GetControllerService, GetProperty, InputStream, Logger, MinifiError, + OutputStream, ProcessError, RouteErrorExt, Schedule, TransformStreamResult, +}; +use pgp::composed::{Message, TheRing}; + +#[derive(Debug, ComponentIdentifier)] +pub(crate) struct DecryptContentPGP { + symmetric_password: Option<pgp::types::Password>, +} + +impl Schedule for DecryptContentPGP { + fn schedule<P: GetProperty + GetControllerService, L>( + context: &P, + _logger: &L, + ) -> Result<Self, MinifiError> + where + Self: Sized, + L: Logger, + { + let symmetric_password = context.get_property(&SYMMETRIC_PASSWORD)?; + let private_key_service = context.get_controller_service(&PRIVATE_KEY_SERVICE)?; + if private_key_service.is_none() && symmetric_password.is_none() { + Err(MinifiError::validation( + "Either Symmetric Password or Private Key Service must be set", + )) + } else { + Ok(DecryptContentPGP { symmetric_password }) + } + } +} + +impl DecryptContentPGP { + fn decrypt_msg<'a>( + &'a self, + msg: Message<'a>, + private_key_service: Option<&'a PGPPrivateKeyService>, + ) -> pgp::errors::Result<Message<'a>> { + let mut ring = if let Some(pks) = private_key_service { + pks.get_the_ring() + } else { + TheRing::default() + }; + + ring.decrypt_options = ring.decrypt_options.enable_gnupg_aead(); + + if let Some(sym_passwd) = &self.symmetric_password { + ring.message_password.push(sym_passwd); + } Review Comment: it can be decrypted with either, its quite smart, pgp generates a single session token it uses that to encrypt the message/file symmetrically and then it encrypts the session token twice, once with public key, once with the configured symmetric key, then saves both results, during decrypiption if it can decrypt the sesion key with either private or symmetric key it can decrypt the file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
