bobpaulin commented on code in PR #11680:
URL: https://github.com/apache/nifi/pull/11680#discussion_r4017561411
##########
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/SwappablePriorityQueue.java:
##########
@@ -1040,6 +1038,21 @@ public SelectiveDropResult dropFlowFiles(final
Predicate<FlowFile> predicate) th
droppedFlowFiles.addAll(result.droppedFlowFiles());
}
+ // Replace rewritten swap files in place so that retained
FlowFiles remain ahead of later swap files.
+ final List<String> updatedSwapLocations = new
ArrayList<>(swapLocations.size());
Review Comment:
Nit but reading this is it is easy to mix up swapLocationUpdates with
updatedSwapLocations as they're the same words reordered. Rewritten matches
the comment and offers some distinction between the 2 variables.
```suggestion
final List<String> rewrittenSwapLocations = new
ArrayList<>(swapLocations.size());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
