Adelwageeh96 commented on PR #11442: URL: https://github.com/apache/nifi/pull/11442#issuecomment-5467811395
Hi @exceptionfactory , thanks for the review. I've removed MSSQL2008DatabaseDialectService and its test as requested — SQL Server 2008 reached end of support in 2019, so the dialect service now only targets SQL Server 2012+. Changes pushed to the branch (commit 6dddce5a01): Removed MSSQL2008DatabaseDialectService.java Removed TestMSSQL2008DatabaseDialectService.java Removed its entry from META-INF/services/org.apache.nifi.controller.ControllerService MSSQLDatabaseDialectService (SELECT with paging, UPSERT via MERGE, ALTER/CREATE DDL) and its tests are unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
