[
https://issues.apache.org/jira/browse/NIFI-3504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15873234#comment-15873234
]
ASF GitHub Bot commented on NIFI-3504:
--------------------------------------
GitHub user apsaltis opened a pull request:
https://github.com/apache/nifi/pull/1520
NIFI-3504 Fixing the encoding and decoding of logicalTypes to match the
Avro 1.7.7 spec
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X ] Is your initial contribution a single, squashed commit?
### For code changes:
- [X ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apsaltis/nifi NIFI-3504
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1520.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1520
----
commit 1fb2a6853563241841b6a7c4bfacd6b326f8047c
Author: Andrew Psaltis <[email protected]>
Date: 2017-02-18T16:03:18Z
NIFI-3504 Fixing the encoding and decoding of logicalTypes to match the
Avro 1.7.7 spec
----
> TransformCSVToAvro and TransformAvroToCSV incorrectly handle logicalTypes
> -------------------------------------------------------------------------
>
> Key: NIFI-3504
> URL: https://issues.apache.org/jira/browse/NIFI-3504
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.2.0
> Reporter: Andrew Psaltis
> Assignee: Andrew Psaltis
>
> The current implementation of the encoding and decoding of Avro logicalTypes
> is inconsistent with the Avro 1.7.7 and 1.8.1 specifications. Currently it is
> assumed that a logical type always has the underlying Avro type of Byte.
> However, that is not consistent with the following text, emphasis mine that
> was extracted from the logical types section of the [Avro
> specification|http://avro.apache.org/docs/1.7.7/spec.html#Logical+Types].
> {quote}
> A logical type *is always serialized using its underlying Avro type* so that
> values are encoded in exactly the same way as the equivalent Avro type that
> does not have a logicalType attribute. Language implementations may choose to
> represent logical types with an appropriate native type, although this is not
> required.
> Language implementations *must ignore unknown logical types when reading, and
> should use the underlying Avro type. If a logical type is invalid, for
> example a decimal with scale greater than its precision, then implementations
> should ignore the logical type and use the underlying Avro type.*
> {quote}
> [1]
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
