fgerlits commented on code in PR #2195:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2195#discussion_r3704626787
##########
libminifi/include/core/reporting/SiteToSiteProvenanceReportingTask.h:
##########
@@ -44,7 +44,7 @@ class SiteToSiteProvenanceReportingTask : public
minifi::RemoteProcessGroupPort
static constexpr char const* ReportTaskName =
"SiteToSiteProvenanceReportingTask";
static const char *ProvenanceAppStr;
- static void getJsonReport(core::ProcessContext& context,
core::ProcessSession& session,
std::vector<std::shared_ptr<core::SerializableComponent>> &records, std::string
&report); // NOLINT
+ static std::string getJsonReport(core::ProcessContext& context,
core::ProcessSession& session, const
std::vector<std::shared_ptr<core::SerializableComponent>> &records); // NOLINT
Review Comment:
can this `// NOLINT` be removed? I guess it used to complain about the
non-const `records` argument
##########
libminifi/include/provenance/Provenance.h:
##########
@@ -233,69 +217,69 @@ class ProvenanceEventRecordImpl : public
core::SerializableComponentImpl, public
bool loadFromRepository(const std::shared_ptr<core::Repository> &repo)
override;
protected:
- ProvenanceEventType _eventType;
+ ProvenanceEventType event_type_;
// Date at which the event was created
- std::chrono::system_clock::time_point _eventTime{};
+ std::chrono::system_clock::time_point event_time_{};
// Date at which the flow file entered the flow
- std::chrono::system_clock::time_point _entryDate{};
+ std::chrono::system_clock::time_point entry_date_{};
// Date at which the origin of this flow file entered the flow
- std::chrono::system_clock::time_point _lineageStartDate{};
- std::chrono::milliseconds _eventDuration{};
- std::string _componentId;
- std::string _componentType;
+ std::chrono::system_clock::time_point lineage_start_date_{};
+ std::chrono::milliseconds event_duration_{};
+ std::string component_id_;
+ std::string component_type_;
// Size in bytes of the data corresponding to this flow file
- uint64_t _size = 0;
+ uint64_t size_ = 0;
utils::Identifier flow_uuid_;
- uint64_t _offset = 0;
- std::string _contentFullPath;
- std::map<std::string, std::string> _attributes;
+ uint64_t offset_ = 0;
+ std::string content_full_path;
+ std::map<std::string, std::string> attributes_;
// UUID string for all parents
- std::vector<utils::Identifier> _lineageIdentifiers;
- std::string _transitUri;
- std::string _sourceSystemFlowFileIdentifier;
- std::vector<utils::Identifier> _parentUuids;
- std::vector<utils::Identifier> _childrenUuids;
- std::string _details;
- std::string _sourceQueueIdentifier;
- std::string _relationship;
- std::string _alternateIdentifierUri;
+ std::vector<utils::Identifier> lineage_identifiers;
Review Comment:
`content_full_path` and `lineage_identifiers` are missing a trailing `_`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
