[
https://issues.apache.org/jira/browse/NIFI-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870781#comment-15870781
]
ASF GitHub Bot commented on NIFI-3494:
--------------------------------------
GitHub user patricker opened a pull request:
https://github.com/apache/nifi/pull/1517
NIFI-3494 GenerateTableFetch Some JDBC Drivers Have Trouble With Name vs
Label
A tiny change to support JDBC drivers that are too helpful.
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/patricker/nifi NIFI-3494
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1517.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1517
----
commit 5d5b477deb1006188500a74065db0f11f720faaa
Author: patricker <[email protected]>
Date: 2017-02-16T21:41:21Z
NIFI-3494
----
> GenerateTableFetch Some JDBC Drivers Have Trouble With Name vs Label
> --------------------------------------------------------------------
>
> Key: NIFI-3494
> URL: https://issues.apache.org/jira/browse/NIFI-3494
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.2.0
> Reporter: Peter Wicks
> Assignee: Peter Wicks
> Priority: Minor
> Fix For: 1.2.0
>
>
> When GenerateTableFetch retrieves the COUNT(*) and the Max Values for the
> columns, some JDBC drivers (specifically SAP HANA) in this case have trouble
> interpreting the name of the column if the "table" is actually a view.
> Since all max value columns are aliased with the original column name I'm
> going to change the code to try Label first, and fall back to Name if it's
> not there.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
