szaszm commented on code in PR #2154:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2154#discussion_r3052165758
##########
extensions/python/PythonBindings.h:
##########
@@ -23,6 +23,14 @@
#include "types/Types.h"
+#define PYTHON_METHOD_BEGIN \
+ try {
+#define PYTHON_METHOD_END \
+ } catch (const std::exception& e) { \
+ PyErr_SetString(PyExc_Exception, e.what()); \
+ return nullptr; \
Review Comment:
Technically correct, but minifi code never throws exceptions that are not
derived from `std::exception` as far as I'm aware. I'd leave it up to you (PR
author) if you want to follow this suggestion or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
