vishal-firgan-ksolves commented on code in PR #11095:
URL: https://github.com/apache/nifi/pull/11095#discussion_r3041045304
##########
nifi-framework-bundle/nifi-framework-extensions/nifi-py4j-framework-bundle/nifi-python-framework/src/main/python/framework/ProcessorInspection.py:
##########
@@ -459,8 +476,13 @@ def get_property_descriptions(class_node,
module_string_constants, module_file,
visitor = CollectPropertyDescriptorVisitors(module_string_constants,
class_node.name, imported_property_descriptors)
visitor.visit(class_node)
- return visitor.discovered_property_descriptors.values()
+ # Merge parent/imported descriptors that are not already defined in the
child class.
+ merged = dict(visitor.discovered_property_descriptors)
+ for name, desc in imported_property_descriptors.items():
+ if name not in merged:
+ merged[name] = desc
+ return merged.values()
Review Comment:
@pvillard31, now merging only imported descriptors that are actually used
during dependency resolution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
