lordgamez commented on code in PR #2045:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2045#discussion_r2888647315


##########
extensions/azure/storage/DataLakeStorageClient.h:
##########
@@ -39,6 +41,7 @@ struct AzureDataLakeStorageParameters {
   std::string file_system_name;
   std::string directory_name;
   std::optional<uint64_t> number_of_retries;
+  std::optional<minifi::controllers::ProxyConfiguration> proxy_configuration;

Review Comment:
   I'm not sure I'm convinced about this. What do you mean by "one more 
impossible state unrepresentable"? It seem a bit unintuitive to me. When the 
user adds a proxy controller service their intention is to use a proxy, if they 
do not want to use a proxy they should not add a service at all. What would be 
the benefit of adding a proxy service and configure it to not to use a proxy?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to