lordgamez commented on code in PR #2128:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2128#discussion_r2879084155


##########
.github/workflows/verify-package.yml:
##########
@@ -85,17 +97,19 @@ jobs:
         if: failure()
         uses: actions/upload-artifact@v4
         with:
-          name: ${{ matrix.platform.id }}_${{ matrix.arch }}_behavex_output${{ 
inputs.enable_fips && '_fips' || '' }}
+          name: ${{ matrix.platform.id }}_${{ matrix.arch }}_behavex_output${{ 
matrix.enable_fips && '_fips' || '' }}
           path: build/behavex_output
 
   docker-test-modular:
     name: "${{ matrix.platform.name }} (${{ matrix.arch }}) Modular"
+    needs: [check-artifacts-workflow]
     runs-on: ${{ matrix.arch == 'x86_64' && 'ubuntu-24.04' || 
'ubuntu-24.04-arm' }}
     timeout-minutes: 240
     strategy:
       fail-fast: false
       matrix:
         arch: [x86_64, aarch64]
+        enable_fips: [true]

Review Comment:
   Note: I think running workflow with both fips enabled and disabled can 
instantiate way too much jobs, so for automatic weekly runs running only fips 
enabled jobs should be sufficient.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to