sfc-gh-mpayne commented on code in PR #70: URL: https://github.com/apache/nifi-api/pull/70#discussion_r2874138257
########## src/main/java/org/apache/nifi/components/connector/components/FlowContextType.java: ########## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.nifi.components.connector.components; + +public enum FlowContextType { + + ACTIVE, + + WORKING; Review Comment: Yeah, I think we definitely need to add docs here to clarify exactly what these are intended to convey. Good catch. I don't think `RUNNING` or `PROCESSING` really fits. Effectively, `ACTIVE` = what can be run, stopped, etc. This is the "real flow." `WORKING` is the "in process" version where users can change configuration, verify connectivity, etc. Once they are happy, they can apply updates, which will migrate the "Working" configuration to the "Active" configuration. Will document this clearly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
