exceptionfactory commented on code in PR #10653: URL: https://github.com/apache/nifi/pull/10653#discussion_r2640243573
########## nifi-extension-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/AbstractAwsProcessor.java: ########## @@ -79,16 +79,16 @@ * @see <a href="https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/auth/credentials/AwsCredentialsProvider.html";>AwsCredentialsProvider</a> */ public abstract class AbstractAwsProcessor<C extends AwsClient, B extends AwsClientBuilder<B, C>> extends AbstractSessionFactoryProcessor implements VerifiableProcessor { - private static final String CREDENTIALS_SERVICE_CLASSNAME = "org.apache.nifi.processors.aws.credentials.provider.service.AWSCredentialsProviderControllerService"; - // Obsolete property names - private static final String OBSOLETE_ACCESS_KEY = "Access Key"; - private static final String OBSOLETE_SECRET_KEY = "Secret Key"; - private static final String OBSOLETE_CREDENTIALS_FILE = "Credentials File"; - private static final String OBSOLETE_PROXY_HOST = "Proxy Host"; - private static final String OBSOLETE_PROXY_PORT = "Proxy Host Port"; - private static final String OBSOLETE_PROXY_USERNAME = "proxy-user-name"; - private static final String OBSOLETE_PROXY_PASSWORD = "proxy-user-password"; + public static final String OBSOLETE_ACCESS_KEY = "Access Key"; + public static final String OBSOLETE_SECRET_KEY = "Secret Key"; + public static final String OBSOLETE_CREDENTIALS_FILE = "Credentials File"; + public static final String OBSOLETE_PROXY_HOST = "Proxy Host"; + public static final String OBSOLETE_PROXY_PORT = "Proxy Host Port"; + public static final String OBSOLETE_PROXY_USERNAME = "proxy-user-name"; + public static final String OBSOLETE_PROXY_PASSWORD = "proxy-user-password"; Review Comment: Thanks for highlighting the concern. With the goal of keeping changes limited to test classes, what do you think about a shared `enum` in the test directory? That would provide a reusable source, without impacting runtime code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
