agturley commented on code in PR #10655:
URL: https://github.com/apache/nifi/pull/10655#discussion_r2637212103
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/prometheusutil/PrometheusMetricsUtil.java:
##########
@@ -478,6 +478,14 @@ public static CollectorRegistry
createAggregatedNifiMetrics(final NiFiMetricsReg
return niFiMetricsRegistry.getRegistry();
}
+ public static void createVersionInfoMetrics(final VersionInfoRegistry
versionInfoRegistry, final String instanceId) {
+ // 1. Retrieve the calculated version details
+ final VersionInfoRegistry.VersionDetails details =
versionInfoRegistry.getVersionDetails();
+ versionInfoRegistry.setDataPoint(1, "NIFI_VERSION_INFO", instanceId,
+ details.nifiVersion, details.javaVersion, details.revision,
details.tag,
+ details.buildBranch, details.osName, details.osVersion,
details.osArchitecture, details.javaVendor);
+}
Review Comment:
made the requested changes. I also changed the the actual output from
"nifi_version" to "framework_version". Should I change this back or leave it
as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
