[
https://issues.apache.org/jira/browse/NIFI-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861794#comment-15861794
]
ASF GitHub Bot commented on NIFI-3362:
--------------------------------------
GitHub user mosermw opened a pull request:
https://github.com/apache/nifi/pull/1501
NIFI-3362 update FlowConfiguration.xsd to allow all current time period
units
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mosermw/nifi NIFI-3362
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1501.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1501
----
commit cda4441ce00f6819646bd06e5a3f7fef1b76a61e
Author: Mike Moser <[email protected]>
Date: 2017-02-10T20:06:16Z
NIFI-3362 update FlowConfiguration.xsd to allow all current time period
units
----
> Update FlowConfiguration.xsd TimePeriod to match FormatUtils
> ------------------------------------------------------------
>
> Key: NIFI-3362
> URL: https://issues.apache.org/jira/browse/NIFI-3362
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 0.7.1, 1.1.1
> Reporter: Michael Moser
> Assignee: Michael Moser
> Priority: Minor
>
> The framework FormatUtils time duration parser has been updated to support
> new terms such as "weeks". But when using those new terms, we get ERROR
> messages in the nifi-bootstrap.log.
> cvc-pattern-valid: Value '4 weeks' is not facet-valid with respect to pattern
> '\d+\s*(ns|nano|nanos|nanoseconds|ms|milli|millis|milliseconds|s|sec|secs|seconds|m|min|mins|minutes|h|hr|hrs|hours|d|day|days)'
> for type 'TimePeriod'.
> cvc-type.3.1.3: The value '4 weeks' of element 'flowFileExpiration' is not
> valid.
> FlowConfiguration.xsd TimePeriod pattern should be updated to match
> FormatUtils.
> Add to FlowConguration.xsd:
> nanosecond
> millisecond
> second
> minute
> hour
> w
> wk
> wks
> week
> weeks
> Add to FormatUtils.java
> nanosecond
> millisecond
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
