martinzink commented on code in PR #2044: URL: https://github.com/apache/nifi-minifi-cpp/pull/2044#discussion_r2469236036
########## behave_framework/src/minifi_test_framework/containers/docker_image_builder.py: ########## @@ -0,0 +1,88 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +import logging +import os +import tempfile +from docker.models.images import Image +from typing import Optional + +import docker Review Comment: good idea, to be honest im not that familiar with python best practices when it comes to formatting, went ahead and reformatted and optimized imports via PyCharm in [auto format via PyCharm](https://github.com/apache/nifi-minifi-cpp/pull/2044/commits/1fe9bd2f06b2ca21645b2dd7548a706dcb4631cd) ########## behave_framework/src/minifi_test_framework/core/hooks.py: ########## @@ -0,0 +1,59 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + + +import logging +import os +from behave.model import Scenario +from behave.runner import Context +from minifi_test_framework.containers.minifi_container import MinifiContainer +from minifi_test_framework.core.minifi_test_context import MinifiTestContext + +import docker Review Comment: good idea, to be honest im not that familiar with python best practices when it comes to formatting, went ahead and reformatted and optimized imports via PyCharm in [auto format via PyCharm](https://github.com/apache/nifi-minifi-cpp/pull/2044/commits/1fe9bd2f06b2ca21645b2dd7548a706dcb4631cd) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
