martinzink commented on code in PR #2044:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2044#discussion_r2466588589
##########
extensions/aws/tests/features/s3.feature:
##########
@@ -19,89 +19,74 @@ Feature: Sending data from MiNiFi-C++ to an AWS server
As a user of MiNiFi
I need to have PutS3Object and DeleteS3Object processors
- Background:
- Given the content of "/tmp/output" is monitored
-
Scenario: A MiNiFi instance transfers encoded data to s3
Given a GetFile processor with the "Input Directory" property set to
"/tmp/input"
- And a file with the content "LH_O#L|FD<FASD{FO#@$#$%^
\"#\"$L%:\"@#$L\":test_data#$#%#$%?{\"F{" is present in "/tmp/input"
- And a PutS3Object processor set up to communicate with an s3 server
- And a PutFile processor with the "Directory" property set to "/tmp/output"
- And the "success" relationship of the GetFile processor is connected to
the PutS3Object
- And the "success" relationship of the PutS3Object processor is connected
to the PutFile
-
- And a s3 server is set up in correspondence with the PutS3Object
-
- When both instances start up
-
- Then a flowfile with the content "test" is placed in the monitored
directory in less than 60 seconds
- And the object on the s3 server is "LH_O#L|FD<FASD{FO#@$#$%^
\"#\"$L%:\"@#$L\":test_data#$#%#$%?{\"F{"
- And the object content type on the s3 server is "application/octet-stream"
and the object metadata matches use metadata
- And the Minifi logs contain the following message: "in a single upload" in
less than 10 seconds
-
- Scenario: A MiNiFi instance transfers encoded data to s3 in FIPS mode
- Given OpenSSL FIPS mode is enabled in MiNiFi
- And a GetFile processor with the "Input Directory" property set to
"/tmp/input"
- And a file with the content "LH_O#L|FD<FASD{FO#@$#$%^
\"#\"$L%:\"@#$L\":test_data#$#%#$%?{\"F{" is present in "/tmp/input"
+ And a directory at "/tmp/input" has a file with the content
"LH_O#L|FD<FASD{FO#@$#$%^ \"#\"$L%:\"@#$L\":test_data#$#%#$%?{\"F{"
And a PutS3Object processor set up to communicate with an s3 server
And a PutFile processor with the "Directory" property set to "/tmp/output"
And the "success" relationship of the GetFile processor is connected to
the PutS3Object
And the "success" relationship of the PutS3Object processor is connected
to the PutFile
+ And the "failure" relationship of the PutS3Object processor is connected
to the PutS3Object
+ And PutFile's success relationship is auto-terminated
- And a s3 server is set up in correspondence with the PutS3Object
+ And an s3 server is set up in correspondence with the PutS3Object
When both instances start up
- Then a flowfile with the content "test" is placed in the monitored
directory in less than 60 seconds
+ Then there is a single file with "LH_O#L|FD<FASD{FO#@$#$%^
\"#\"$L%:\"@#$L\":test_data#$#%#$%?{\"F{" content in the "/tmp/output"
directory in less than 20 seconds
And the object on the s3 server is "LH_O#L|FD<FASD{FO#@$#$%^
\"#\"$L%:\"@#$L\":test_data#$#%#$%?{\"F{"
And the object content type on the s3 server is "application/octet-stream"
and the object metadata matches use metadata
And the Minifi logs contain the following message: "in a single upload" in
less than 10 seconds
Scenario: A MiNiFi instance transfers encoded data through a http proxy to s3
Given a GetFile processor with the "Input Directory" property set to
"/tmp/input"
- And a file with the content "LH_O#L|FD<FASD{FO#@$#$%^
\"#\"$L%:\"@#$L\":test_data#$#%#$%?{\"F{" is present in "/tmp/input"
+ And a directory at "/tmp/input" has a file with the content
"LH_O#L|FD<FASD{FO#@$#$%^ \"#\"$L%:\"@#$L\":test_data#$#%#$%?{\"F{"
And a PutS3Object processor set up to communicate with an s3 server
- And these processor properties are set to match the http proxy:
- | processor name | property name | property value |
- | PutS3Object | Proxy Host | http-proxy-${feature_id} |
- | PutS3Object | Proxy Port | 3128 |
- | PutS3Object | Proxy Username | admin |
- | PutS3Object | Proxy Password | test101 |
+ And these processor properties are set
+ | processor name | property name | property value |
+ | PutS3Object | Proxy Host | http-proxy-s3-1 |
Review Comment:
good idea,
https://github.com/apache/nifi-minifi-cpp/pull/2044/commits/b4557124d87c6c7f035ead0fa2d1758585756213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
