rfellows commented on code in PR #10423:
URL: https://github.com/apache/nifi/pull/10423#discussion_r2433687927
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/cluster/ui/cluster-provenance-storage-listing/cluster-provenance-storage-listing.component.ts:
##########
@@ -70,8 +75,11 @@ export class ClusterProvenanceStorageListing {
})
);
- isInitialLoading(loadedTimestamp: string): boolean {
- return loadedTimestamp == initialClusterState.loadedTimestamp;
+ isInitialLoading(loadedTimestamp: string,
systemDiagnosticsLoadedTimestamp: string): boolean {
+ return (
+ loadedTimestamp == initialClusterState.loadedTimestamp ||
+ systemDiagnosticsLoadedTimestamp ==
initialSystemDiagnosticsState.loadedTimestamp
+ );
Review Comment:
I think this (and other instances) would be a great candidate to use a
computed signal. something like:
```
isInitialLoading = computed(() =>
this.loadedTimestamp() == initialClusterState.loadedTimestamp ||
this.systemDiagnosticsLoadedTimestamp() ==
initialSystemDiagnosticsState.loadedTimestamp
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
