exceptionfactory commented on PR #10401:
URL: https://github.com/apache/nifi/pull/10401#issuecomment-3381683793

   > @exceptionfactory Based on further testing, it looks Salesforce expires 
the session even if the access token has no expiration time. So maybe it would 
be a better approach to add a user configurable `Expiration Time` property to 
`StandardOauth2AccessTokenProvider` (as in case of 
`JWTBearerOAuth2AccessTokenProvider`) and use this value as default when no 
expiration time is provided. Please give me some time to test it thoroughly and 
put the review on hold till then. Thanks
   
   Thanks for the update, I will hold off on further feedback until you have 
run through some additional tests. Perhaps introducing a strategy property, 
something like `Expiration Handling` with `Access Token` and `Configured` as 
possible values, where `Configured` requires an explicit `Expiration Period` 
property could work for this generic service. I'm open to considering options. 
It may also require something more specific for Salesforce, so that is another 
thing to keep in mind in terms of scoping potential changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to