Mihhai commented on PR #10353:
URL: https://github.com/apache/nifi/pull/10353#issuecomment-3380486426

   > good change, don't worry about the c2-server we'll update accordingly, 
does this also add the processor status to the heartbeat, or was that already 
included?
   
   Yes it does, and while we're at it i'd also like to mention that [looking at 
the current 
implementation](https://github.com/apache/nifi/blob/main/minifi/minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-framework-core/src/main/java/org/apache/nifi/minifi/c2/C2NifiClientService.java#L404)
 i noticed the heartbeat’s FlowInfo seems to include only processors and 
connection queues that are direct children of the root process group. In my 
tests, if the root group only contains sub process groups (and those hold the 
actual processors/queues), those inner components do not appear in the 
heartbeat payload. I assume this isnt the intended behaviour, should i treat 
this as a bug? If so, should i sneak in a fix for this in this pr also?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to