fgerlits commented on code in PR #1986:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1986#discussion_r2379810881
##########
libminifi/test/unit/GeneralUtilsTest.cpp:
##########
@@ -27,55 +27,55 @@
namespace org::apache::nifi::minifi::test {
// intdiv_ceil
-static_assert(0 == utils::intdiv_ceil(0, 1));
-static_assert(0 == utils::intdiv_ceil(0, 2));
-static_assert(1 == utils::intdiv_ceil(1, 2));
-static_assert(1 == utils::intdiv_ceil(1, 3));
-static_assert(1 == utils::intdiv_ceil(3, 3));
-static_assert(2 == utils::intdiv_ceil(4, 3));
-static_assert(2 == utils::intdiv_ceil(5, 3));
-static_assert(0 == utils::intdiv_ceil(-1, 3));
-static_assert(-1 == utils::intdiv_ceil(-3, 3));
-static_assert(-1 == utils::intdiv_ceil(-4, 3));
-static_assert(2 == utils::intdiv_ceil(-4, -3));
-static_assert(2 == utils::intdiv_ceil(-5, -3));
-static_assert(0 == utils::intdiv_ceil(1, -3));
-static_assert(-1 == utils::intdiv_ceil(5, -3));
-static_assert(3 == utils::intdiv_ceil(6, 2));
-static_assert(-3 == utils::intdiv_ceil(-6, 2));
-static_assert(-3 == utils::intdiv_ceil(6, -2));
-static_assert(3 == utils::intdiv_ceil(-6, -2));
-static_assert(0 == utils::intdiv_ceil(0, -10));
+static_assert(0 == minifi::utils::intdiv_ceil(0, 1));
+static_assert(0 == minifi::utils::intdiv_ceil(0, 2));
+static_assert(1 == minifi::utils::intdiv_ceil(1, 2));
+static_assert(1 == minifi::utils::intdiv_ceil(1, 3));
+static_assert(1 == minifi::utils::intdiv_ceil(3, 3));
+static_assert(2 == minifi::utils::intdiv_ceil(4, 3));
+static_assert(2 == minifi::utils::intdiv_ceil(5, 3));
+static_assert(0 == minifi::utils::intdiv_ceil(-1, 3));
+static_assert(-1 == minifi::utils::intdiv_ceil(-3, 3));
+static_assert(-1 == minifi::utils::intdiv_ceil(-4, 3));
+static_assert(2 == minifi::utils::intdiv_ceil(-4, -3));
+static_assert(2 == minifi::utils::intdiv_ceil(-5, -3));
+static_assert(0 == minifi::utils::intdiv_ceil(1, -3));
+static_assert(-1 == minifi::utils::intdiv_ceil(5, -3));
+static_assert(3 == minifi::utils::intdiv_ceil(6, 2));
+static_assert(-3 == minifi::utils::intdiv_ceil(-6, 2));
+static_assert(-3 == minifi::utils::intdiv_ceil(6, -2));
+static_assert(3 == minifi::utils::intdiv_ceil(-6, -2));
+static_assert(0 == minifi::utils::intdiv_ceil(0, -10));
template<int N, int D, typename = void>
struct does_compile : std::false_type {};
template<int N, int D>
struct does_compile<N, D,
Review Comment:
this is a bit misleading: `intdiv_ceil(123, 0)` does compile, it just
doesn't compile as a constant expression (because it throws)
```suggestion
struct compiles_as_a_constant_expression<N, D,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
