fgerlits commented on code in PR #2034:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2034#discussion_r2371923043
##########
PROCESSORS.md:
##########
@@ -722,7 +722,7 @@ In the list below, the names of required properties appear
in bold. Any other pr
### Description
-Executes a script given the flow file and a process session. The script is
responsible for handling the incoming flow file (transfer to SUCCESS or remove,
e.g.) as well as any flow files created by the script. If the handling is
incomplete or incorrect, the session will be rolled back. Scripts must define
an onTrigger function which accepts NiFi Context and ProcessSession objects.
Scripts are executed once when the processor is run, then the onTrigger method
is called for each incoming flowfile. This enables scripts to keep state if
they wish. The python script files are expected to contain
`describe(processor)` and `onTrigger(context, session)`.
+DEPRECATED. This processor should only be used internally for running NiFi and
MiNiFi C++ style python processors. Do not use this processor in your own
flows, move your python processors to the minifi-python directory instead,
where they will be parsed, and then they can be used with their filename as the
processor class in the flow configuration. This processor executes a script
given the flow file and a process session. The script is responsible for
handling the incoming flow file (transfer to SUCCESS or remove, e.g.) as well
as any flow files created by the script. If the handling is incomplete or
incorrect, the session will be rolled back. Scripts must define an onTrigger
function which accepts NiFi Context and ProcessSession objects. Scripts are
executed once when the processor is run, then the onTrigger method is called
for each incoming flowfile. This enables scripts to keep state if they wish.
The python script files are expected to contain `describe(processor)` and
`onTrig
ger(context, session)`.
Review Comment:
nitpicking, but maybe put a line break (or two) between the deprecation
warning and the legacy description to separate them better visually
##########
extensions/python/ExecutePythonProcessor.h:
##########
@@ -105,7 +111,7 @@ class ExecutePythonProcessor : public core::ProcessorImpl {
return python_properties_;
}
- bool getPythonSupportDynamicProperties() {
+ bool supportsDynamicProperties() const override {
return python_dynamic_;
}
Review Comment:
I would move this to just before line 92 and make it single-line; that would
make it clearer to someone reading the code why we are not using the full
standard `ADD_COMMON_VIRTUAL_FUNCTIONS_FOR_PROCESSORS` set of functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
