exceptionfactory commented on code in PR #10186:
URL: https://github.com/apache/nifi/pull/10186#discussion_r2276814000
##########
nifi-extension-bundles/nifi-github-bundle/nifi-github-extensions/src/main/java/org/apache/nifi/github/GitHubRepositoryClient.java:
##########
@@ -276,8 +299,13 @@ public List<GitCommit> getCommits(final String path, final
String branch) throws
.toList();
final List<GitCommit> commits = new ArrayList<>();
+ int i = 0;
for (final GHCommit ghCommit : ghCommits) {
+ if (i >= MAX_COMMITS_TO_RETRIEVE) {
+ break;
+ }
Review Comment:
Limiting this after retrieval does not seem like the best approach. The Page
Size appears to limit the current number to 50. Would it be sufficient to
switch that to 10?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
