lordgamez commented on code in PR #1990:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1990#discussion_r2254293299


##########
PROCESSORS.md:
##########
@@ -433,10 +436,15 @@ In the list below, the names of required properties 
appear in bold. Any other pr
 
 ### Output Attributes
 
-| Attribute   | Relationship | Description               |
-|-------------|--------------|---------------------------|
-| mqtt.broker |              | URI of the sending broker |
-| mqtt.topic  |              | Topic of the message      |
+| Attribute            | Relationship | Description                            
                                                                                
               |
+|----------------------|--------------|---------------------------------------------------------------------------------------------------------------------------------------|
+| mqtt.broker          |              | URI of the sending broker              
                                                                                
               |
+| mqtt.topic           |              | Topic of the message                   
                                                                                
               |
+| mqtt.topic.segment.n |              | The nth topic segment of the message   
                                                                                
               |
+| mqtt.qos             |              | The quality of service for this 
message.                                                                        
                      |
+| mqtt.isDuplicate     |              | Whether or not this message might be a 
duplicate of one which has already been received.                               
               |
+| mqtt.isRetained      |              | Whether or not this message was from a 
current publisher, or was "retained" by the server as the last message 
published on the topic. |

Review Comment:
   Added info on this in the description in 
https://github.com/apache/nifi-minifi-cpp/pull/1990/commits/7e2cad557da32447caada0536e44ada143104195



##########
docker/test/integration/features/steps/steps.py:
##########
@@ -435,6 +436,18 @@ def step_impl(context):
     context.test.start('mqtt-broker')
 
 
+@given("a SparkplugBReader controller service is set up")
+def step_impl(context):
+    json_record_set_reader = SparkplugBReader("SparkplugBReader")
+    container = context.test.acquire_container(context=context, 
name="minifi-cpp-flow")
+    container.add_controller(json_record_set_reader)

Review Comment:
   Updated in 
https://github.com/apache/nifi-minifi-cpp/pull/1990/commits/7e2cad557da32447caada0536e44ada143104195



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to