mark-bathori commented on PR #10031: URL: https://github.com/apache/nifi/pull/10031#issuecomment-3095831091
Thanks @turcsanyip for the review. The main idea behind the current implementation was to completely separate any Couchbase SDK-specific logic and attributes from the processor level. This is why the bucket, scope, and collection attributes are defined on the controller service. I'm unsure if we can assume these properties will exist in future SDK versions, considering the scope attribute didn't exist in SDK 2. For example, if a new abstraction level were introduced in the next SDK, it would require modifications to the processors, which is something I aimed to avoid. I agree that configuring the controller service with fixed values for bucket, scope, and collection isn't the best approach. I agree that it would be better if these could get values from FlowFile attributes, so users don't need to configure multiple Controller Services for different bucket, scope, and collection values. Regarding the double controller service layer, it seemed like a good idea to separate cluster initialization-specific properties from database action-related ones. However, I'm not against merging them into a single service. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
