[ 
https://issues.apache.org/jira/browse/NIFI-3429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849271#comment-15849271
 ] 

ASF GitHub Bot commented on NIFI-3429:
--------------------------------------

GitHub user nickcarenza opened a pull request:

    https://github.com/apache/nifi/pull/1464

    NIFI-3429 automatically quoting all table identifiers

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nickcarenza/nifi NIFI-3429

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1464.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1464
    
----
commit 27fb5d5e297b69b51e794fb57f42fba0cb02f361
Author: Nick Carenza <[email protected]>
Date:   2017-02-02T01:50:34Z

    automatically quoting all table identifiers

----


> ConvertJSONToSQL Does not work with table identifiers that need to be quoted
> ----------------------------------------------------------------------------
>
>                 Key: NIFI-3429
>                 URL: https://issues.apache.org/jira/browse/NIFI-3429
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>            Reporter: Nicholas Carenza
>
> I have a table identifer that needs to be quoted. If i supple the table 
> identifer unquoted in the properties, the processor can convert the json to 
> sql but the output sql doesn't have the table name quoted even if I select 
> the option Quote Identifiers because, true to the description, it only 
> applies to column identifiers. If I supply the table identifier quoted in the 
> properties, then the processor fails completely because it can't find the 
> table.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to