szaszm commented on code in PR #1983: URL: https://github.com/apache/nifi-minifi-cpp/pull/1983#discussion_r2161877485
########## extensions/expression-language/ProcessContextExpr.cpp: ########## Review Comment: I've pushed a few changes that don't change behavior, just restructure the code, lmk if you disagree with anything. Also, I was wondering if access to the ProcessContext is synchronized at all, or are we doing concurrent unsynchronized accesses (i.e. data race) to non-static data members like cached_dynamic_expressions_. That's a separate bug, but similarly very important. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
