szaszm commented on code in PR #1977:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1977#discussion_r2140499392
##########
extensions/sql/processors/ExecuteSQL.cpp:
##########
@@ -53,7 +53,7 @@ void ExecuteSQL::processOnTrigger(core::ProcessContext&
context, core::ProcessSe
if (!query) {
if (!input_flow_file) {
throw Exception(PROCESSOR_EXCEPTION,
- "No incoming FlowFile and the \"" +
std::string{SQLSelectQuery.name} + "\" processor property is not specified");
+ "No incoming FlowFile and the \"" +
std::string(SQLSelectQuery.name) + "\" processor property is not specified");
Review Comment:
I prefer the old version, or if we change this line, I'd change more:
- no aligned continuation
- concat with string utils, or format with fmt
- uniform init the exception object
I think we should just revert this to the old version.
##########
.github/workflows/ci.yml:
##########
Review Comment:
is this gonna run the linter on both linux and windows sources?
##########
minifi-api/include/minifi-cpp/core/ContentRepository.h:
##########
@@ -38,7 +38,8 @@ namespace org::apache::nifi::minifi::core {
/**
* Content repository definition that extends StreamManager.
*/
-class ContentRepository : public virtual core::CoreComponent, public virtual
StreamManager<minifi::ResourceClaim>, public virtual
utils::EnableSharedFromThis, public virtual core::RepositoryMetricsSource {
+class ContentRepository : public virtual core::CoreComponent, public virtual
StreamManager<minifi::ResourceClaim>,
+ public virtual utils::EnableSharedFromThis, public
virtual core::RepositoryMetricsSource {
Review Comment:
continuations shouldn't be aligned. I'd either keep the long line, or use
two levels of indentation (4 spaces) as continuation indentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
