mcgilman commented on code in PR #9697:
URL: https://github.com/apache/nifi/pull/9697#discussion_r2132863394
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/users/feature/users.component.spec.ts:
##########
@@ -34,7 +35,13 @@ describe('Users', () => {
beforeEach(() => {
TestBed.configureTestingModule({
declarations: [Users, UserListing],
- imports: [RouterModule, RouterTestingModule,
MockComponent(BannerText), MockComponent(Navigation)],
+ imports: [
+ RouterModule,
+ RouterTestingModule,
+ MockComponent(BannerText),
+ MockComponent(Navigation),
+ MockComponent(NgxSkeletonLoaderComponent)
Review Comment:
I don't think this component uses the skeleton loader so mocking here
shouldn't be needed. I realize this PR been open for some time so it's possible
the components changed since opening.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]