sardell commented on code in PR #9855: URL: https://github.com/apache/nifi/pull/9855#discussion_r2082567150
########## nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/app.component.html: ########## @@ -0,0 +1,21 @@ +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one or more + ~ contributor license agreements. See the NOTICE file distributed with + ~ this work for additional information regarding copyright ownership. + ~ The ASF licenses this file to You under the Apache License, Version 2.0 + ~ (the "License"); you may not use this file except in compliance with + ~ the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> + +<div class="flex flex-col h-screen"> + <app-header></app-header> Review Comment: Thanks for the logo suggestion! I'll give that a try. I have [a Jira task](https://issues.apache.org/jira/browse/NIFI-13940) open with subtasks (NIFI-14319 is one of them). The tickets are broken down by views. I don't believe the remaining PRs will be nearly as large as this one initializing the project, but I also now know that breaking down by view is not granular enough. I'll work on breaking these down further asap. I'd rather address shared components separately to avoid having to deal with rebase conflicts in a PR like this one. Having a dedicated PR for promoting a handful of components from NiFi into the shared lib should be a very straightforward refactor and shouldn't take nearly as long to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
