sardell commented on code in PR #9855: URL: https://github.com/apache/nifi/pull/9855#discussion_r2077987346
########## nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/app.component.html: ########## @@ -0,0 +1,21 @@ +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one or more + ~ contributor license agreements. See the NOTICE file distributed with + ~ this work for additional information regarding copyright ownership. + ~ The ASF licenses this file to You under the Apache License, Version 2.0 + ~ (the "License"); you may not use this file except in compliance with + ~ the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> + +<div class="flex flex-col h-screen"> + <app-header></app-header> Review Comment: I'll be sure to update the text color to use secondary-contrast. In regard to the svg, I think it might be time for a logo refresh? Perhaps it could include the name like NiFi's logo and I can remove this not-so-great-looking header. As a temporary solution, I could override the theme to utilize the old header color in light mode. What do you think? With regard to using a shared component for the header, I'm very much in support of this. I think we could create a very simplistic component which leverages Angular's content projection, but I'm open to different ideas. The approach I wanted to take with this big piece of work is utilize shared components that currently exist, and make note of components that should be created and shared to be addressed after migrating the Registry UI. How does that sit with you? I can track it as a separate epic in Jira, or I can create tickets in this epic and address them once I have most of the application migrated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
