mcgilman commented on code in PR #9884:
URL: https://github.com/apache/nifi/pull/9884#discussion_r2061324283
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/parameter-contexts/ui/parameter-context-listing/parameter-context-table/parameter-context-table.component.ts:
##########
@@ -86,6 +86,19 @@ export class ParameterContextTable {
return this.canRead(entity) && entity.component ?
entity.component.description : '';
}
+ formatProcessGroups(entity: ParameterContextEntity): string {
+ return this.canRead(entity) && entity.component ?
this.getHighLevelProcessGroups(entity.component) : '';
+ }
+
+ private getHighLevelProcessGroups(component: ParameterContext) : string {
+ const componentIds: string[] = component.boundProcessGroups.map(group
=> group.component.id)
Review Comment:
We need to account for the current users permissions here. When the user
lacks permissions to the given Parameter Context or any bound process group
this throws an error causing rendering issues in the UI.
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/parameter-contexts/ui/parameter-context-listing/parameter-context-table/parameter-context-table.component.ts:
##########
@@ -21,7 +21,7 @@ import { MatSortModule, Sort } from '@angular/material/sort';
import { NiFiCommon } from '@nifi/shared';
import { FlowConfiguration } from '../../../../../state/flow-configuration';
import { CurrentUser } from '../../../../../state/current-user';
-import { ParameterContextEntity } from '../../../../../state/shared';
+import {ParameterContext, ParameterContextEntity} from
'../../../../../state/shared';
Review Comment:
Please fix the formatting here. This can be accomplished by running:
`$ npx nx prettier:format`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
