lordgamez commented on code in PR #1903: URL: https://github.com/apache/nifi-minifi-cpp/pull/1903#discussion_r2037476018
########## extensions/llamacpp/processors/RunLlamaCppInference.cpp: ########## @@ -0,0 +1,166 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include "RunLlamaCppInference.h" +#include "core/ProcessContext.h" +#include "core/ProcessSession.h" +#include "core/Resource.h" +#include "Exception.h" + +#include "rapidjson/document.h" +#include "rapidjson/error/en.h" +#include "LlamaContext.h" + +namespace org::apache::nifi::minifi::extensions::llamacpp::processors { + +namespace { + +std::optional<float> parseOptionalFloatProperty(const core::ProcessContext& context, const core::PropertyReference& property) { + std::string str_value; + if (!context.getProperty(property, str_value) || str_value.empty()) { + return std::nullopt; + } + try { + return std::stof(str_value); + } catch(const std::exception&) { + throw Exception(PROCESS_SCHEDULE_EXCEPTION, fmt::format("Property '{}' has invalid value '{}'", property.name, str_value)); + } +} + +std::optional<int32_t> parseOptionalInt32Property(const core::ProcessContext& context, const core::PropertyReference& property) { + std::string str_value; + if (!context.getProperty(property, str_value) || str_value.empty()) { + return std::nullopt; + } + try { + return gsl::narrow<int32_t>(std::stoi(str_value)); + } catch(const std::exception&) { + throw Exception(PROCESS_SCHEDULE_EXCEPTION, fmt::format("Property '{}' has invalid value '{}'", property.name, str_value)); + } +} + +} // namespace + +void RunLlamaCppInference::initialize() { + setSupportedProperties(Properties); + setSupportedRelationships(Relationships); +} + +void RunLlamaCppInference::onSchedule(core::ProcessContext& context, core::ProcessSessionFactory&) { + model_path_.clear(); + context.getProperty(ModelPath, model_path_); + context.getProperty(SystemPrompt, system_prompt_); + + LlamaSamplerParams llama_sampler_params; + llama_sampler_params.temperature = parseOptionalFloatProperty(context, Temperature); + llama_sampler_params.top_k = parseOptionalInt32Property(context, TopK); + llama_sampler_params.top_p = parseOptionalFloatProperty(context, TopP); + llama_sampler_params.min_p = parseOptionalFloatProperty(context, MinP); + + uint64_t uint_value = 0; + if (context.getProperty(MinKeep, uint_value)) { + llama_sampler_params.min_keep = uint_value; + } + + LlamaContextParams llama_ctx_params; + if (context.getProperty(TextContextSize, uint_value)) { + llama_ctx_params.n_ctx = gsl::narrow_cast<uint32_t>(uint_value); + } + if (context.getProperty(LogicalMaximumBatchSize, uint_value)) { + llama_ctx_params.n_batch = gsl::narrow_cast<uint32_t>(uint_value); + } + if (context.getProperty(PhysicalMaximumBatchSize, uint_value)) { + llama_ctx_params.n_ubatch = gsl::narrow_cast<uint32_t>(uint_value); + } + if (context.getProperty(MaxNumberOfSequences, uint_value)) { + llama_ctx_params.n_seq_max = gsl::narrow_cast<uint32_t>(uint_value); + } + int32_t int_value = 0; + if (context.getProperty(ThreadsForGeneration, int_value)) { + llama_ctx_params.n_threads = gsl::narrow_cast<int32_t>(int_value); + } + if (context.getProperty(ThreadsForBatchProcessing, int_value)) { + llama_ctx_params.n_threads_batch = gsl::narrow_cast<int32_t>(int_value); + } + + llama_ctx_ = LlamaContext::create(model_path_, llama_sampler_params, llama_ctx_params); +} + +void RunLlamaCppInference::onTrigger(core::ProcessContext& context, core::ProcessSession& session) { + auto input_ff = session.get(); + if (!input_ff) { + context.yield(); + return; + } + + std::string prompt; + context.getProperty(Prompt, prompt, input_ff.get()); + + auto read_result = session.readBuffer(input_ff); + std::string input_data_and_prompt; + if (!read_result.buffer.empty()) { + input_data_and_prompt.append("Input data (or flow file content):\n"); + input_data_and_prompt.append({reinterpret_cast<const char*>(read_result.buffer.data()), read_result.buffer.size()}); + input_data_and_prompt.append("\n\n"); + } + input_data_and_prompt.append(prompt); + + std::string input = [&] { + std::vector<LlamaChatMessage> messages; + messages.push_back({.role = "system", .content = system_prompt_}); + messages.push_back({.role = "user", .content = input_data_and_prompt}); + + return llama_ctx_->applyTemplate(messages); + }(); + + logger_->log_debug("AI model input: {}", input); + + auto start_time = std::chrono::steady_clock::now(); + + std::string text; + auto number_of_tokens_generated = llama_ctx_->generate(input, [&] (std::string_view token) { + text += token; + }); + + auto elapsed_time = std::chrono::duration_cast<std::chrono::milliseconds>(std::chrono::steady_clock::now() - start_time).count(); + + if (!number_of_tokens_generated) { + logger_->log_error("Inference failed with generation error: '{}'", number_of_tokens_generated.error()); + session.transfer(input_ff, Failure); + return; + } + + auto ff_guard = gsl::finally([&] { + session.remove(input_ff); + }); + + logger_->log_debug("Number of tokens generated: {}", *number_of_tokens_generated); + logger_->log_debug("AI model inference time: {} ms", elapsed_time); + logger_->log_debug("AI model output: {}", text); + + auto result = session.create(); + session.writeBuffer(result, text); + session.transfer(result, Success); Review Comment: Good point, probably it was used only when dynamic relationships were used, updated in https://github.com/apache/nifi-minifi-cpp/pull/1903/commits/86cf24d3a23204cd9d313bdf254d04bdbb9dc1f8 ########## extensions/llamacpp/processors/LlamaContext.cpp: ########## @@ -0,0 +1,39 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include "LlamaContext.h" +#include "Exception.h" +#include "fmt/format.h" +#include "llama.h" Review Comment: Removed in https://github.com/apache/nifi-minifi-cpp/pull/1903/commits/86cf24d3a23204cd9d313bdf254d04bdbb9dc1f8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
