martinzink commented on code in PR #1940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1940#discussion_r2035259172
##########
extensions/opc/src/fetchopc.cpp:
##########
@@ -32,153 +32,136 @@
namespace org::apache::nifi::minifi::processors {
- void FetchOPCProcessor::initialize() {
- setSupportedProperties(Properties);
- setSupportedRelationships(Relationships);
- }
+void FetchOPCProcessor::initialize() {
+ setSupportedProperties(Properties);
+ setSupportedRelationships(Relationships);
+}
- void FetchOPCProcessor::onSchedule(core::ProcessContext& context,
core::ProcessSessionFactory& factory) {
- logger_->log_trace("FetchOPCProcessor::onSchedule");
+void FetchOPCProcessor::onSchedule(core::ProcessContext& context,
core::ProcessSessionFactory& factory) {
+ logger_->log_trace("FetchOPCProcessor::onSchedule");
- translatedNodeIDs_.clear(); // Path might has changed during restart
+ translated_node_ids_.clear(); // Path might has changed during restart
- BaseOPCProcessor::onSchedule(context, factory);
+ BaseOPCProcessor::onSchedule(context, factory);
- nodeID_ = context.getProperty(NodeID).value_or("");
- std::string value = context.getProperty(NodeIDType).value_or("");
+ node_id_ = context.getProperty(NodeID).value_or("");
Review Comment:
Since NodeID is required we can safely parse it like this
```suggestion
node_id_ = utils::parseProperty(context, NodeID);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
