pvillard31 commented on PR #9848: URL: https://github.com/apache/nifi/pull/9848#issuecomment-2785763002
Thanks @exceptionfactory for the feedback. Great point on deletion. My thoughts were really in the context of showing changes between two versions (n and n+1) and in my mind, whoever is looking at the changes is most likely already familiar with version n, so I thought that showing only that the process group (and its content) was deleted is enough because I assumed that the person already knows what was inside the deleted process group. When adding a process group, there is no way to already know what's inside. That's the way I approached it. I can definitely also consider full details for the removal of a process group. I do agree with you that the existing strategy `DEEP` had a good meaning but it sounds like this is more about the level of metadata being returned rather than "deep" in the sense of recursive listing. I did think about just updating the DEEP strategy and I'm OK taking this approach to be honest, I was just concerned about potential side effects on existing APIs that rely on this (show local changes for versioned process groups being one). With this additional context, do you have any preference? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
