bobpaulin commented on code in PR #9793:
URL: https://github.com/apache/nifi/pull/9793#discussion_r1997662927
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/IdentifyMimeType.java:
##########
@@ -111,31 +110,19 @@ public class IdentifyMimeType extends AbstractProcessor {
.defaultValue(PRESET.getValue())
.build();
- public static final PropertyDescriptor MIME_CONFIG_FILE = new
PropertyDescriptor.Builder()
- .displayName("Config File")
- .name("config-file")
- .required(false)
- .description("Path to MIME type config file. Only one of Config
File or Config Body may be used.")
- .addValidator(new StandardValidators.FileExistsValidator(true))
- .expressionLanguageSupported(ExpressionLanguageScope.ENVIRONMENT)
- .dependsOn(CONFIG_STRATEGY, REPLACE, MERGE)
- .build();
-
- public static final PropertyDescriptor MIME_CONFIG_BODY = new
PropertyDescriptor.Builder()
- .displayName("Config Body")
- .name("config-body")
- .required(false)
- .description("Body of MIME type config file. Only one of Config
File or Config Body may be used.")
- .addValidator(Validator.VALID)
- .expressionLanguageSupported(ExpressionLanguageScope.NONE)
+ public static final PropertyDescriptor CUSTOM_MIME_CONFIGURATION = new
PropertyDescriptor.Builder()
+ .name("Custom Configuration")
Review Comment:
Hi as a Tika contributor it would be helpful if this were named "Custom MIME
Configuration" to help distinguish this from the more popular tika-config.xml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
