[ 
https://issues.apache.org/jira/browse/MINIFICPP-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932311#comment-17932311
 ] 

Ferenc Gerlits commented on MINIFICPP-1811:
-------------------------------------------

{{CollectorInitiatedSubscription}} was removed as part of MINIFICPP-2429.

> CollectorInitiatedSubscription is weird and untested
> ----------------------------------------------------
>
>                 Key: MINIFICPP-1811
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-1811
>             Project: Apache NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Ferenc Gerlits
>            Priority: Minor
>              Labels: MiNiFi-CPP-Hygiene
>
> The Windows-only {{CollectorInitiatedSubscription}} processor lists its 
> properties differently from all other processors: instead of having {{static 
> const Property}} fields, it has a non-static {{subscriptionName_}} field 
> which contains {{Property*}} pointers, which are copied into {{Property}} 
> objects in {{{}initialize(){}}}. The properties are wrapped into a 
> {{SupportedProperty}} class which is not used anywhere else.
> There are also no unit tests for this processor.
> If this processor is not required, we should remove it.
> If it is required, then we need to write unit tests for it, and change the 
> way it uses properties to the pattern used by other processors.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to